-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG][12.0] fleet vehicle service kanban: Backport 13.0 to 12.0 #12
[MIG][12.0] fleet vehicle service kanban: Backport 13.0 to 12.0 #12
Conversation
Hi @mamcode, @ivantodorovich, |
eed6d85
to
bed7878
Compare
@ivantodorovich I have some problem on fleet_vehicle_log_services_views with <activity> view. I disabled <widget> section on fleet_vehicle_log_services_view_form to avoid runbot error. |
8d9f612
to
331ec6d
Compare
@ivantodorovich As before, I commented the content of <activity> and for this I don't found help. |
9148d28
to
21eab0d
Compare
fleet_vehicle_service_kanban/views/fleet_vehicle_log_services_views.xml
Outdated
Show resolved
Hide resolved
fleet_vehicle_service_kanban/views/fleet_vehicle_log_services_views.xml
Outdated
Show resolved
Hide resolved
21eab0d
to
8f193c0
Compare
@ivantodorovich There is another problem: I don't know why "Activity Types" menu don't show (and why it is double on v 13.0) |
Hi @mymage the menu is shown only in debug mode, because it has the base.group_no_one group. There are 2 menues because 1 is coming from the standard And the other one is the one in this module: activity types for services I've tested and it works ok! good job! |
Well, learned one more thing :-)
Thank you, now I will proceed with the last one when this will be merged. |
@ivantodorovich ping ;-) to merge this to complete #11 |
We need another member to approve the PR before merging 😅 |
@mamcode can you please give a look/review to this PR? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Done, thanks for backport. |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 37b7042. Thanks a lot for contributing to OCA. ❤️ |
Backportig from 13.0