Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][12.0] fleet vehicle service kanban: Backport 13.0 to 12.0 #12

Merged
merged 4 commits into from
Jun 17, 2020

Conversation

mymage
Copy link
Member

@mymage mymage commented Jun 8, 2020

Backportig from 13.0

@OCA-git-bot
Copy link
Contributor

Hi @mamcode, @ivantodorovich,
some modules you are maintaining are being modified, check this out!

@mymage mymage force-pushed the 12.0-mig-fleet_vehicle_service_kanban branch 8 times, most recently from eed6d85 to bed7878 Compare June 8, 2020 20:38
@mymage
Copy link
Member Author

mymage commented Jun 8, 2020

@ivantodorovich I have some problem on fleet_vehicle_log_services_views with <activity> view.
I commented the code to pass Travis.
I googled for activity view on v12 and if I understood it is not available like on v13.
Do you confirm that or do you have some reference do suggest?

I disabled <widget> section on fleet_vehicle_log_services_view_form to avoid runbot error.

@mymage mymage force-pushed the 12.0-mig-fleet_vehicle_service_kanban branch 3 times, most recently from 8d9f612 to 331ec6d Compare June 9, 2020 20:05
@mymage mymage marked this pull request as ready for review June 9, 2020 20:48
@mymage
Copy link
Member Author

mymage commented Jun 9, 2020

@ivantodorovich As before, I commented the content of <activity> and for this I don't found help.
I commented <widget> too and I think that can be substituted with a label.

@mymage mymage force-pushed the 12.0-mig-fleet_vehicle_service_kanban branch 2 times, most recently from 9148d28 to 21eab0d Compare June 9, 2020 21:35
@mymage mymage marked this pull request as draft June 10, 2020 10:01
@mymage mymage force-pushed the 12.0-mig-fleet_vehicle_service_kanban branch from 21eab0d to 8f193c0 Compare June 10, 2020 10:46
@mymage mymage marked this pull request as ready for review June 10, 2020 10:53
@mymage
Copy link
Member Author

mymage commented Jun 10, 2020

@ivantodorovich There is another problem: I don't know why "Activity Types" menu don't show (and why it is double on v 13.0)

@ivantodorovich
Copy link

Hi @mymage

the menu is shown only in debug mode, because it has the base.group_no_one group.

image

There are 2 menues because 1 is coming from the standard fleet module, and those are activity types for vehicles.

And the other one is the one in this module: activity types for services

I've tested and it works ok! good job!

@mymage
Copy link
Member Author

mymage commented Jun 11, 2020

the menu is shown only in debug mode, because it has the base.group_no_one group.

Well, learned one more thing :-)

I've tested and it works ok! good job!

Thank you, now I will proceed with the last one when this will be merged.

@mymage
Copy link
Member Author

mymage commented Jun 16, 2020

@ivantodorovich ping ;-) to merge this to complete #11

@ivantodorovich
Copy link

We need another member to approve the PR before merging 😅

@mymage
Copy link
Member Author

mymage commented Jun 16, 2020

@mamcode can you please give a look/review to this PR? Thanks

Copy link
Member

@mamcode mamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mamcode
Copy link
Member

mamcode commented Jun 16, 2020

@mamcode can you please give a look/review to this PR? Thanks

Done, thanks for backport.

@ivantodorovich
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-12-by-ivantodorovich-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 505de34 into OCA:12.0 Jun 17, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 37b7042. Thanks a lot for contributing to OCA. ❤️

@mymage mymage deleted the 12.0-mig-fleet_vehicle_service_kanban branch December 17, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants